Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix address binding for "examples/sm_manager" #87

Merged
merged 2 commits into from
Dec 24, 2019
Merged

fix address binding for "examples/sm_manager" #87

merged 2 commits into from
Dec 24, 2019

Conversation

HAOYUatHZ
Copy link
Contributor

@HAOYUatHZ HAOYUatHZ commented Dec 16, 2019 •
edited

"examples/sm_manager" is implemented using https://rocket.rs/

Current config Rocket.toml is incompatible with #88

This PR fixes the address config to support running sm_manager in docker.

@HAOYUatHZ
Copy link
Contributor Author

Hi @gbenattar
you can just simply run ./demo/run.sh to test this PR
(This PR is to change sm_manager binding address in Rocket server config)
it works good on my machine

@HAOYUatHZ HAOYUatHZ changed the title fix address binding for rocket server fix address binding for "examples/sm_manager" Dec 23, 2019
@HAOYUatHZ HAOYUatHZ mentioned this pull request Dec 23, 2019
Open
@gbenattar
Copy link
Contributor

LGTM as long as it is good for @omershlo. You can go ahead and squash and merge.

@omershlo omershlo merged commit b68db7a into ZenGo-X:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbenattar gbenattar gbenattar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HAOYUatHZ @gbenattar @omershlo